New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): use correct ICU plural for locale mk #24659

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@ocombe
Contributor

ocombe commented Jun 25, 2018

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

The library generating ICU Plural functions wasn't up to date with the current version of CLDR

What is the new behavior?

Library updated, only one ICU plural function was changed (for locale mk)

Does this PR introduce a breaking change?

[x] No
@mary-poppins

This comment has been minimized.

mary-poppins commented Jun 25, 2018

You can preview bfeb086 at https://pr24659-bfeb086.ngbuilds.io/.

@ocombe ocombe requested review from alexeagle, jasonaden and mhevery and removed request for alexeagle and jasonaden Jun 25, 2018

@jasonaden

This comment has been minimized.

Contributor

jasonaden commented Jun 25, 2018

Approved build/ci changes.

jasonaden added a commit that referenced this pull request Jun 27, 2018

@jasonaden jasonaden closed this in 39c8bae Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment