Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): properly update collection reference in NgForOf #24684

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@trotyl
Copy link
Contributor

commented Jun 27, 2018

closes #24155

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #24155

What is the new behavior?

Properly update collection reference for each subview when using alias.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes label Jun 27, 2018

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2018

Travis failure seems to be unrelated.

@ngbot

This comment has been minimized.

Copy link

commented Jun 27, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery

This comment has been minimized.

Copy link
Member

commented Jun 27, 2018

Thank you.

@mhevery

This comment has been minimized.

@mhevery mhevery closed this in ff84c5c Jun 29, 2018

mhevery added a commit that referenced this pull request Jun 29, 2018

@trotyl trotyl deleted the trotyl:ng-for-of-as branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.