New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protractor_web_test & protractor_web_test_suite #24787

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@gregmagolan
Contributor

gregmagolan commented Jul 6, 2018

Replaces #24370

@gregmagolan gregmagolan requested a review from alexeagle Jul 6, 2018

@googlebot

This comment has been minimized.

googlebot commented Jul 6, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 6, 2018

@gregmagolan gregmagolan referenced this pull request Jul 6, 2018

Closed

Bazel protrator tests #24788

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 9, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 10, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 10, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 10, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 10, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 11, 2018

@alexeagle alexeagle added cla: yes and removed cla: no labels Jul 11, 2018

@googlebot

This comment has been minimized.

googlebot commented Jul 11, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

url = "https://github.com/bazelbuild/rules_nodejs/archive/0.9.1.zip",
strip_prefix = "rules_nodejs-0.9.1",
sha256 = "6139762b62b37c1fd171d7f22aa39566cb7dc2916f0f801d505a9aaf118c117f",
url = "https://github.com/gregmagolan/rules_nodejs/archive/bba77118cb18c7fdefa9cd4612d0477ab045a2c4.zip",

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

rules_nodejs is released now, should have what you need?

WORKSPACE Outdated
@@ -11,11 +11,20 @@ http_archive(
sha256 = "2f77623311da8b5009b1c7eade12de8e15fa3cd2adf9dfcc9f87cb2082b2211f",
)
http_archive(

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

comment why we need this?

url = "https://github.com/bazelbuild/rules_webtesting/archive/v0.2.0.zip",
strip_prefix = "rules_webtesting-0.2.0",
sha256 = "cecc12f07e95740750a40d38e8b14b76fefa1551bef9332cb432d564d693723c",
url = "https://github.com/bazelbuild/rules_webtesting/archive/8fd9ce0fd9254bde251da0bc373d6cd08e811434.zip",

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

should we ask them for a release?

data = [
"index.html",
":bundle",
":zone.js",
],
entry_point = "http-server/bin/http-server",
templated_args = ["src"],

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

don't I still need to specify a port for when I run the prodserver manually? what if I had two http-server targets and wanted to run both? would I give extra args on the bazel run command line instead?

This comment has been minimized.

@gregmagolan

gregmagolan Jul 11, 2018

Contributor

yup. you could pass command line arguments. without them then you'd get the default port for prodserver.

import { browser } from 'protractor';
import {OnPrepareConfig, runServer} from '@angular/bazel/protractor-utils';
export = function(config: OnPrepareConfig) {

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

we'll need some docs explaining what bits you copy into your app, could be separate PR

import {OnPrepareConfig, runServer} from '@angular/bazel/protractor-utils';
export = function(config: OnPrepareConfig) {
const portFlag = config.server.endsWith('prodserver') ? '-p' : '-port';

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

comment why there are different flags

This comment has been minimized.

@gregmagolan

gregmagolan Jul 11, 2018

Contributor

depending on if ts_devserver is running or http-server

This comment has been minimized.

@gregmagolan

gregmagolan Jul 11, 2018

Contributor

will add a comment

**remaining_keyword_args)
web_test_suite(
name=name,

This comment has been minimized.

@alexeagle

alexeagle Jul 11, 2018

Contributor

ugh the duplication is pretty gross :(

mrmeku and others added some commits Apr 9, 2018

feat(bazel): Initial commit of protractor_web_test_suite
Co-authored-by: Andrew Z Allen <me@andrewzallen.com>
@googlebot

This comment has been minimized.

googlebot commented Jul 11, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 11, 2018

@googlebot

This comment has been minimized.

googlebot commented Jul 11, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 11, 2018

@googlebot

This comment has been minimized.

googlebot commented Jul 11, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 11, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jul 11, 2018

@mhevery mhevery added cla: yes and removed cla: no labels Jul 11, 2018

@googlebot

This comment has been minimized.

googlebot commented Jul 11, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mhevery

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment