New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): warn if navigation triggered outside Angular zone #24959

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@trotyl
Contributor

trotyl commented Jul 18, 2018

closes #15770, closes #15946, closes #24728

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #24728

What is the new behavior?

Produce a warning when router navigation triggered outside Angular zone with NgZone enabled on dev mode.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes label Jul 18, 2018

@@ -91,7 +91,8 @@ function isUrlHandlingStrategy(opts: ExtraOptions | UrlHandlingStrategy):
export function setupTestingRouter(
urlSerializer: UrlSerializer, contexts: ChildrenOutletContexts, location: Location,
loader: NgModuleFactoryLoader, compiler: Compiler, injector: Injector, routes: Route[][],
opts?: ExtraOptions, urlHandlingStrategy?: UrlHandlingStrategy): Router;
opts?: ExtraOptions, urlHandlingStrategy?: UrlHandlingStrategy, console?: Console,

This comment has been minimized.

@trotyl

trotyl Jul 19, 2018

Contributor

This doesn't make sense, Console is a private API and cannot be part of public API declaration.

@matsko

This comment has been minimized.

@jasonaden jasonaden self-assigned this Sep 4, 2018

mhevery added a commit that referenced this pull request Sep 5, 2018

@mhevery mhevery closed this in 010e35d Sep 5, 2018

@timdeschryver timdeschryver referenced this pull request Oct 6, 2018

Merged

feat: update angular dependencies to V7 #1354

1 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment