New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): specify the package and lock files using the workspace #25694

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@alan-agius4
Contributor

alan-agius4 commented Aug 28, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
When used downstream (CLI), The following error is being thrown

no such package '@ts-api-guardian_runtime_deps//': Unable to load package for //tools/ts-api-guardian:package.json: not found. and referenced by '//etc/api:angular_devkit_schematics_tasks_api'

no such package 'tools/ts-api-guardian': BUILD file not found on package path and referenced by '//etc/api:angular_devkit_schematics_testing_api.accept'
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

//cc @alexeagle

@googlebot googlebot added the cla: yes label Aug 28, 2018

@alan-agius4 alan-agius4 changed the title from fix(bazel): specify the package and lock files using the workspace to fix(bazel): specify the package and lock files using the workspace (WIP) Aug 28, 2018

@alan-agius4 alan-agius4 changed the title from fix(bazel): specify the package and lock files using the workspace (WIP) to fix(bazel): specify the package and lock files using the workspace Aug 28, 2018

Show resolved Hide resolved tools/ts-api-guardian/index.bzl Outdated
@alan-agius4

This comment has been minimized.

Contributor

alan-agius4 commented Sep 7, 2018

alan-agius4 added some commits Aug 28, 2018

feat(bazel): add additional parameters to `ts_api_guardian_test` def
Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream
@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Sep 7, 2018

This PR doesn't apply cleanly to the patch branch. @alan-agius4 can you send a separate PR for that branch please?

@alan-agius4

This comment has been minimized.

Contributor

alan-agius4 commented Sep 7, 2018

@IgorMinar IgorMinar closed this in ddc1335 Sep 7, 2018

IgorMinar added a commit that referenced this pull request Sep 7, 2018

feat(bazel): add additional parameters to `ts_api_guardian_test` def (#…
…25694)

Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream

PR Close #25694

alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 18, 2018

feat(bazel): add additional parameters to `ts_api_guardian_test` def (a…
…ngular#25694)

Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream

PR Close angular#25694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment