New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch of fixes related to g3 support #25775

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@alxhub
Contributor

alxhub commented Aug 31, 2018

No description provided.

@googlebot googlebot added the cla: yes label Aug 31, 2018

@alxhub alxhub requested a review from benlesh Aug 31, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Aug 31, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Sep 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Sep 5, 2018

@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Sep 6, 2018

review missing.

@mary-poppins

This comment has been minimized.

mary-poppins commented Sep 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Sep 7, 2018

@mhevery

mhevery approved these changes Sep 7, 2018

alxhub added some commits Aug 28, 2018

fix(ivy): add @nocollapse when writing closure-annotated code
Closure requires @nocollapse on Ivy definition static fields in order
to not convert them to standalone constants. However tsickle, the tool
which would ordinarily be responsible for adding @nocollapse, doesn't
properly annotate fields which are added synthetically via transforms.
So this commit adds @nocollapse by applying regular expressions against
code during the final write to disk.
feat(ivy): support bootstrap in ngModuleDef
The bootstrap property of @NgModule was not previously compiled by
the compiler in AOT or JIT modes (in Ivy). This commit adds support
for bootstrap.
feat(ivy): resolve references to vars in .d.ts files
Previously, if ngtsc encountered a VariableDeclaration without an
initializer, it would assume that the variable was undefined, and
return that result.

However, for symbols exported from external modules that resolve to
.d.ts files, variable declarations are of the form:

export declare let varName: Type;

This form also lacks an initializer, but indicates the presence of an
importable symbol which can be referenced. This commit changes the
static resolver to understand variable declarations with the 'declare'
keyword and to generate references when it encounters them.
fix(ivy): ensure Ivy *Ref classes derive from view engine equivalents
Various user code uses 'instanceof' to check whether a particular instance
is a TemplateRef, ElementRef, etc. Ivy needs to work with these checks.
@mary-poppins

This comment has been minimized.

mary-poppins commented Sep 7, 2018

@alxhub

This comment has been minimized.

Contributor

alxhub commented Sep 10, 2018

Travis is green but has not updated on GH.

@alxhub alxhub removed the request for review from benlesh Sep 10, 2018

@IgorMinar IgorMinar closed this in a0c4b2d Sep 11, 2018

IgorMinar added a commit that referenced this pull request Sep 11, 2018

feat(ivy): support bootstrap in ngModuleDef (#25775)
The bootstrap property of @NgModule was not previously compiled by
the compiler in AOT or JIT modes (in Ivy). This commit adds support
for bootstrap.

PR Close #25775

IgorMinar added a commit that referenced this pull request Sep 11, 2018

feat(ivy): resolve references to vars in .d.ts files (#25775)
Previously, if ngtsc encountered a VariableDeclaration without an
initializer, it would assume that the variable was undefined, and
return that result.

However, for symbols exported from external modules that resolve to
.d.ts files, variable declarations are of the form:

export declare let varName: Type;

This form also lacks an initializer, but indicates the presence of an
importable symbol which can be referenced. This commit changes the
static resolver to understand variable declarations with the 'declare'
keyword and to generate references when it encounters them.

PR Close #25775

IgorMinar added a commit that referenced this pull request Sep 11, 2018

fix(ivy): ensure Ivy *Ref classes derive from view engine equivalents (
…#25775)

Various user code uses 'instanceof' to check whether a particular instance
is a TemplateRef, ElementRef, etc. Ivy needs to work with these checks.

PR Close #25775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment