Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-worker): ignore passive mixed content requests #25994

Closed
wants to merge 1 commit into
base: master
from

Conversation

@gkalpak
Copy link
Member

gkalpak commented Sep 18, 2018

PR Checklist

PR Type

[x] Bugfix

What is the current behavior?

Passive mixed content requests (like images) result in an error. This is a ServiceWorker limitation. Without the ServiceWorker, such requests only produce a warning. See #23012 (comment) for more details.

Issue Number: #23012

What is the new behavior?

The ServiceWorker will ignore such requests and let them be handled by the browser directly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fixes #23012.

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 18, 2018

@gkalpak gkalpak force-pushed the gkalpak:fix-sw-passive-mixed-content branch 2 times, most recently from ea58b3b to ba751f0 Sep 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 18, 2018

@gkalpak gkalpak force-pushed the gkalpak:fix-sw-passive-mixed-content branch from ba751f0 to 805c538 Sep 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 18, 2018

@gkalpak gkalpak force-pushed the gkalpak:fix-sw-passive-mixed-content branch from 805c538 to b8ced23 Jan 16, 2019

@gkalpak gkalpak requested a review from angular/fw-service-worker as a code owner Jan 16, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 16, 2019

@gkalpak gkalpak added the risk: low label Jan 16, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 16, 2019

@IgorMinar
Copy link
Member

IgorMinar left a comment

thanks for great commit message!

@IgorMinar IgorMinar removed the request for review from alxhub Mar 2, 2019

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Mar 2, 2019

this PR needs a rebase to drop the pull approve pending check - otherwise lgtm

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Mar 2, 2019

merge-assistance: please rebase before merging and verify that the CI is still green, if not please ask @gkalpak to help

fix(service-worker): ignore passive mixed content requests
Although [passive mixed content][1] requests (like images) only produce
a warning without a ServiceWorker, fetching it via a ServiceWorker
results in an error. See
#23012 (comment)
for more details.

This commit makes the ServiceWorker ignore such requests and let them be
handled by the browser directly to avoid breaking apps that would work
without the ServiceWorker.

[1]: https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content#passive_mixed_content

Fixes #23012

@AndrewKushnir AndrewKushnir force-pushed the gkalpak:fix-sw-passive-mixed-content branch from b8ced23 to cc6da57 Mar 4, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Mar 4, 2019

@gkalpak I've rebased this PR on top of the latest master. Could you please have a quick look at the changes to see if everything looks good and put the "merge" label back? Thank you.

@gkalpak

This comment has been minimized.

Copy link
Member Author

gkalpak commented Mar 4, 2019

@AndrewKushnir, looks good. Thx!

AndrewKushnir added a commit that referenced this pull request Mar 4, 2019

fix(service-worker): ignore passive mixed content requests (#25994)
Although [passive mixed content][1] requests (like images) only produce
a warning without a ServiceWorker, fetching it via a ServiceWorker
results in an error. See
#23012 (comment)
for more details.

This commit makes the ServiceWorker ignore such requests and let them be
handled by the browser directly to avoid breaking apps that would work
without the ServiceWorker.

[1]: https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content#passive_mixed_content

Fixes #23012

PR Close #25994

@gkalpak gkalpak deleted the gkalpak:fix-sw-passive-mixed-content branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.