Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): mark actual descendant node as disabled #26180

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@JoostK
Copy link
Contributor

JoostK commented Sep 29, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Looking through the code, IntelliJ marked a variable as unused which in this case is wrong.

What is the new behavior?

Descendant disabled nodes will actually be marked as such.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@matsko I don't see relevant tests nor do I know how to reproduce this, so no test was provided for now. If you can give me pointers how this may be tested, please let me know.

@googlebot googlebot added the cla: yes label Sep 29, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 13, 2018

@matsko matsko added the freq1: low label Dec 13, 2018

@matsko matsko self-requested a review Dec 13, 2018

@matsko

matsko approved these changes Dec 13, 2018

@matsko

This comment has been minimized.

Copy link
Member

matsko commented Dec 13, 2018

@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 14, 2018

Can we add a test?

@mhevery mhevery closed this in df123e0 Dec 14, 2018

mhevery added a commit that referenced this pull request Dec 14, 2018

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.