Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): Bazel workspace schematics #26971

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@kyliau
Copy link
Member

kyliau commented Nov 6, 2018

This commit creates a schematics for Bazel workspace.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from alexeagle Nov 6, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 6, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no label Nov 6, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 525ba62 to 3bb009f Nov 6, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 6, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch 2 times, most recently from 0f8ef5d to 4bd7ff7 Nov 7, 2018

@kara kara added the comp: bazel label Nov 7, 2018

@ngbot ngbot bot added this to the needsTriage milestone Nov 7, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 4bd7ff7 to 6b8f1df Nov 8, 2018

@kyliau kyliau modified the milestones: needsTriage, v7.0 Nov 8, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 6b8f1df to 6ee228b Nov 8, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 8, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch 3 times, most recently from 3e72dd3 to 8390fe5 Nov 9, 2018

@kyliau kyliau added cla: yes and removed cla: no labels Nov 13, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 13, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 8390fe5 to 02ca430 Nov 13, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 13, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 13, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 13, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 13, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 02ca430 to 31bb0da Nov 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 14, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 31bb0da to 5dcb4a1 Nov 14, 2018

@kyliau kyliau added cla: yes and removed cla: no labels Nov 14, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 14, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 5dcb4a1 to f058997 Nov 14, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 14, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 14, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from f058997 to e6b7279 Nov 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 14, 2018

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from e6b7279 to 2786599 Nov 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 14, 2018

feat(bazel): Bazel workspace schematics
This commit creates a schematics for Bazel workspace.

@kyliau kyliau force-pushed the kyliau:bazel_workspace branch from 2786599 to ea3a19c Nov 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 14, 2018

@kyliau kyliau added cla: yes and removed cla: no labels Nov 14, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 14, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mhevery mhevery closed this in b07bd30 Nov 16, 2018

mhevery added a commit that referenced this pull request Nov 16, 2018

feat(bazel): Bazel workspace schematics (#26971)
This commit creates a schematics for Bazel workspace.

PR Close #26971

@kyliau kyliau deleted the kyliau:bazel_workspace branch Nov 20, 2018

kyliau added a commit to kyliau/angular that referenced this pull request Nov 20, 2018

kyliau added a commit to kyliau/angular that referenced this pull request Nov 20, 2018

kyliau added a commit to kyliau/angular that referenced this pull request Nov 20, 2018

kyliau added a commit to kyliau/angular that referenced this pull request Nov 20, 2018

mhevery added a commit that referenced this pull request Nov 21, 2018

Revert "feat(bazel): Bazel workspace schematics (#26971)" (#27202)
* Revert "feat(bazel): Bazel workspace schematics (#26971)"

This reverts commit 41b5ea1.

* refactor(bazel): remove workaround for TS bug (#26516)

PR Close #26516

FrederikSchlemmer added a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

feat(bazel): Bazel workspace schematics (angular#26971)
This commit creates a schematics for Bazel workspace.

PR Close angular#26971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.