Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): KeyValuePipe should return empty array for empty objects #27258

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Airblader
Copy link
Contributor

Airblader commented Nov 24, 2018

This lets KeyValuePipe return an empty array (rather than undefined)
when the input is an empty object.

PR Checklist

Please check if your PR fulfills the following requirements:

I don't think this requires explicit clarification in the docs, so no changes there.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

KeyValuePipe returns undefined on empty objects.

Issue Number: #27243

What is the new behavior?

KeyValuePipe returns empty array on empty objects.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Nov 24, 2018

@Airblader Airblader force-pushed the Airblader:fix-27243 branch from 7fa8e41 to ac2b2db Nov 24, 2018

fix(common): KeyValuePipe should return empty array for empty objects
This lets KeyValuePipe return an empty array (rather than undefined)
when the input is empty.

@Airblader Airblader force-pushed the Airblader:fix-27243 branch from ac2b2db to 54b8c0f Nov 24, 2018

@alxhub alxhub added the comp: common label Dec 11, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 11, 2018

@mhevery

This comment has been minimized.

@mhevery mhevery self-assigned this Dec 13, 2018

mhevery added a commit that referenced this pull request Dec 14, 2018

fix(common): KeyValuePipe should return empty array for empty objects (
…#27258)

This lets KeyValuePipe return an empty array (rather than undefined)
when the input is empty.

PR Close #27258

@mhevery mhevery closed this in b39efdd Dec 14, 2018

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(common): KeyValuePipe should return empty array for empty objects (
…angular#27258)

This lets KeyValuePipe return an empty array (rather than undefined)
when the input is empty.

PR Close angular#27258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.