Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): ng-new schematics with Bazel #27277

Closed
wants to merge 1 commit into from
Closed

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Nov 26, 2018

This commit creates a schematics for ng new command that builds
the project with Bazel.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins
Copy link

You can preview 6301b7c at https://pr27277-6301b7c.ngbuilds.io/.

@kyliau kyliau added the area: bazel Issues related to the published `@angular/bazel` build rules label Nov 26, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 26, 2018
@kyliau kyliau added the feature Issue that requests a new feature label Nov 26, 2018
@kyliau kyliau requested a review from vikerman November 27, 2018 00:19
@kyliau kyliau added the target: major This PR is targeted for the next major release label Nov 30, 2018
@mary-poppins
Copy link

You can preview 45961e7 at https://pr27277-45961e7.ngbuilds.io/.

This commit creates a schematics for ng new command that builds
the project with Bazel.
@mary-poppins
Copy link

You can preview b472a99 at https://pr27277-b472a99.ngbuilds.io/.

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Dec 3, 2018
@alxhub alxhub closed this in 06d4a0c Dec 3, 2018
@kyliau kyliau deleted the ng_new branch December 3, 2018 23:16
gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 22, 2018
The test was cherry-picked from angular#27719 into 7.1.x, where entry module
path ended in `/main`, not `/main.dev`. It was changed to `/main.dev`
in angular#27277, which was not backported to 7.1.x.
matsko pushed a commit that referenced this pull request Dec 25, 2018
The test was cherry-picked from #27719 into 7.1.x, where entry module
path ended in `/main`, not `/main.dev`. It was changed to `/main.dev`
in #27277, which was not backported to 7.1.x.
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
This commit creates a schematics for ng new command that builds
the project with Bazel.

PR Close angular#27277
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
This commit creates a schematics for ng new command that builds
the project with Bazel.

PR Close angular#27277
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes feature Issue that requests a new feature target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants