New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): ng-new schematics with Bazel #27277

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@kyliau
Copy link
Member

kyliau commented Nov 26, 2018

This commit creates a schematics for ng new command that builds
the project with Bazel.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Nov 26, 2018

@kyliau kyliau force-pushed the kyliau:ng_new branch 5 times, most recently from af752e3 to 6301b7c Nov 26, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 26, 2018

@kyliau kyliau added the comp: bazel label Nov 26, 2018

@ngbot ngbot bot added this to the needsTriage milestone Nov 26, 2018

@kyliau kyliau requested a review from vikerman Nov 27, 2018

@kyliau kyliau force-pushed the kyliau:ng_new branch from 6301b7c to 45961e7 Dec 1, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 1, 2018

feat(bazel): ng-new schematics with Bazel
This commit creates a schematics for ng new command that builds
the project with Bazel.

@kyliau kyliau force-pushed the kyliau:ng_new branch from 45961e7 to b472a99 Dec 1, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 1, 2018

@alxhub alxhub closed this in 06d4a0c Dec 3, 2018

@kyliau kyliau deleted the kyliau:ng_new branch Dec 3, 2018

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 22, 2018

test(bazel): fix `bazel-workspace` schematics test
The test was cherry-picked from angular#27719 into 7.1.x, where entry module
path ended in `/main`, not `/main.dev`. It was changed to `/main.dev`
in angular#27277, which was not backported to 7.1.x.

matsko added a commit that referenced this pull request Dec 25, 2018

test(bazel): fix `bazel-workspace` schematics test
The test was cherry-picked from #27719 into 7.1.x, where entry module
path ended in `/main`, not `/main.dev`. It was changed to `/main.dev`
in #27277, which was not backported to 7.1.x.

FrederikSchlemmer added a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

feat(bazel): ng-new schematics with Bazel (angular#27277)
This commit creates a schematics for ng new command that builds
the project with Bazel.

PR Close angular#27277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment