New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): tsickle dependency not working with typescript 3.1.x #27402

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@devversion
Copy link
Member

devversion commented Dec 2, 2018

@angular/bazel currently requires TypeScript 3.1.x as a peer dependency, but comes with tsickle as dependency. The current version of tsickle that is specified by @angular/bazel does not support TypeScript 3.1.x (which is a peer dependency) and therefore we need to make sure that tsickle works with the required TypeScript versions.

This change updates tsickle to the latest version that comes with angular/tsickle@b10fb6d in order to work with TypeScript 3.1.x.

fix(bazel): tsickle dependency not working with typescript 3.1.x
`@angular/bazel` currently requires TypeScript 3.1.x as a peer dependency, but comes with `tsickle` as dependency. The current version of `tsickle` that is specified by `@angular/bazel` does not support TypeScript 3.1.x (which is a peer dependency) and therefore we need to make sure that `tsickle` works with the required TypeScript versions.

This change updates `tsickle` to the latest version that comes with angular/tsickle@b10fb6d in order to work with TypeScript 3.1.x.
@@ -19,7 +19,7 @@
"@schematics/angular": "^7.0.4",
"@types/node": "6.0.84",
"shelljs": "0.8.2",
"tsickle": "0.32.1"
"tsickle": "0.34.0"

This comment has been minimized.

@alexeagle

alexeagle Dec 4, 2018

Contributor

shouldn't it also move to be a peer dependency?

This comment has been minimized.

@devversion

devversion Dec 4, 2018

Author Member

Ups sorry. I didn't update the PR description to match the commit message. I don't want to make this a peer dependency (yet) because it would be a breaking change

This comment has been minimized.

@IgorMinar

IgorMinar Dec 7, 2018

Member

It shouldn't be a peer dep. See: #27536 (comment)

@alxhub alxhub closed this in f034114 Dec 7, 2018

alxhub added a commit that referenced this pull request Dec 7, 2018

fix(bazel): tsickle dependency not working with typescript 3.1.x (#27402
)

`@angular/bazel` currently requires TypeScript 3.1.x as a peer dependency, but comes with `tsickle` as dependency. The current version of `tsickle` that is specified by `@angular/bazel` does not support TypeScript 3.1.x (which is a peer dependency) and therefore we need to make sure that `tsickle` works with the required TypeScript versions.

This change updates `tsickle` to the latest version that comes with angular/tsickle@b10fb6d in order to work with TypeScript 3.1.x.

PR Close #27402

@angular angular deleted a comment from mary-poppins Dec 26, 2018

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(bazel): tsickle dependency not working with typescript 3.1.x (ang…
…ular#27402)

`@angular/bazel` currently requires TypeScript 3.1.x as a peer dependency, but comes with `tsickle` as dependency. The current version of `tsickle` that is specified by `@angular/bazel` does not support TypeScript 3.1.x (which is a peer dependency) and therefore we need to make sure that `tsickle` works with the required TypeScript versions.

This change updates `tsickle` to the latest version that comes with angular/tsickle@b10fb6d in order to work with TypeScript 3.1.x.

PR Close angular#27402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment