feat(router): add pathParamsOrQueryParamsChange mode for runGuardsAndResolvers #27464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview e9fd440 at https://pr27464-e9fd440.ngbuilds.io/. |
alxhub
approved these changes
Dec 4, 2018
|
The only thing I would suggest is adding some detail to the commit description - what the motivation for the new mode is, etc :) |
jasonaden
force-pushed
the
FW-744_guards_on_path_query_changes
branch
from
e9fd440
to
0aaa097
Compare
jasonaden
added
action: merge
|
You can preview 0aaa097 at https://pr27464-0aaa097.ngbuilds.io/. |
IgorMinar
suggested changes
Dec 4, 2018
IgorMinar
added
the
action: cleanup
jasonaden
force-pushed
the
FW-744_guards_on_path_query_changes
branch
from
0aaa097
to
b005f21
Compare
jasonaden
changed the title
|
You can preview b005f21 at https://pr27464-b005f21.ngbuilds.io/. |
jasonaden
force-pushed
the
FW-744_guards_on_path_query_changes
branch
from
b005f21
to
1fb4cc5
Compare
jasonaden
removed
the
action: cleanup
|
You can preview 1fb4cc5 at https://pr27464-1fb4cc5.ngbuilds.io/. |
IgorMinar
added
the
action: cleanup
|
@jasonaden can you please rebase? |
IgorMinar
approved these changes
Dec 5, 2018
…Resolvers This option means guards and resolvers will ignore changes to matrix parameters. Guards and resolvers will be rerun when the path changes, when path parameters change, or when query parameters change. The primary use case for such a mode is when updating the UI and getting the URL to be in sync with local changes. For example, if displaying a sortable table, changing the sort direction is often handled by the table itself. But you would want to update the URL to be in sync with what's being displayed to the user. As long as the table sort direction is stored as a matrix parameter, you can use this option to update the URL without causing the overhead of re-running guards and resolvers. Related to angular#26861 angular#18253
jasonaden
force-pushed
the
FW-744_guards_on_path_query_changes
branch
from
1fb4cc5
to
6cf6539
Compare
|
You can preview 6cf6539 at https://pr27464-6cf6539.ngbuilds.io/. |
jasonaden
removed
the
action: cleanup
IgorMinar
added
action: cleanup
jasonaden
added a commit
to jasonaden/angular
that referenced
this pull request
Dec 14, 2018
This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers. Related to angular#26861 angular#18253 angular#27464
jasonaden
added a commit
to jasonaden/angular
that referenced
this pull request
Dec 17, 2018
This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers. Related to angular#26861 angular#18253 angular#27464
mhevery
pushed a commit
that referenced
this pull request
Dec 18, 2018
…27682) This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers. Related to #26861 #18253 #27464 PR Close #27682
IgorMinar
pushed a commit
to IgorMinar/angular
that referenced
this pull request
Dec 19, 2018
…ngular#27682) This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers. Related to angular#26861 angular#18253 angular#27464 PR Close angular#27682
IgorMinar
pushed a commit
to IgorMinar/angular
that referenced
this pull request
Dec 19, 2018
…ngular#27682) This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers. Related to angular#26861 angular#18253 angular#27464 PR Close angular#27682
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…Resolvers (angular#27464) This option means guards and resolvers will ignore changes to matrix parameters. Guards and resolvers will be rerun when the path changes, when path parameters change, or when query parameters change. The primary use case for such a mode is when updating the UI and getting the URL to be in sync with local changes. For example, if displaying a sortable table, changing the sort direction is often handled by the table itself. But you would want to update the URL to be in sync with what's being displayed to the user. As long as the table sort direction is stored as a matrix parameter, you can use this option to update the URL without causing the overhead of re-running guards and resolvers. Related to angular#26861 angular#18253 PR Close angular#27464
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…Resolvers (angular#27464) This option means guards and resolvers will ignore changes to matrix parameters. Guards and resolvers will be rerun when the path changes, when path parameters change, or when query parameters change. The primary use case for such a mode is when updating the UI and getting the URL to be in sync with local changes. For example, if displaying a sortable table, changing the sort direction is often handled by the table itself. But you would want to update the URL to be in sync with what's being displayed to the user. As long as the table sort direction is stored as a matrix parameter, you can use this option to update the URL without causing the overhead of re-running guards and resolvers. Related to angular#26861 angular#18253 PR Close angular#27464
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ngular#27682) This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers. Related to angular#26861 angular#18253 angular#27464 PR Close angular#27682
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option means guards and resolvers will ignore changes to matrix parameters. Guards and resolvers will be rerun when the path changes, when path parameters change, or when query parameters change.
Related to #26861 #18253