New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): compiler compliance tests actualized #27473

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@AndrewKushnir
Contributor

AndrewKushnir commented Dec 5, 2018

PR #27404 introduced additional test case to make sure we generate elementStyling instructions with proper set of arguments (first argument was missing in some cases). It looks like that PR was created before we updated host vars count calculation and the allocHostVars becomes unnecessary in the test cases introduced in PR #27404. This commit actualizes this test to get rid of unnecessary allocHostVars instruction.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No
fix(ivy): compiler compliance tests actualized
PR #27404 introduced additional test case to make sure we generate `elementStyling` instructions with proper set of arguments (first argument was missing in some cases). It looks like that PR was created before we updated host vars count calculation and the `allocHostVars` becomes unnecessary in the test cases introduced in PR #27404. This commit actualizes this test to get rid of unnecessary `allocHostVars` instruction.
@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@AndrewKushnir AndrewKushnir force-pushed the AndrewKushnir:compiler_compliance_tests_fix branch from f016031 to 0bfc5c1 Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment