New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): enable ivy tests for platform-browser/animations #27478

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@ocombe
Contributor

ocombe commented Dec 5, 2018

Enable ivy tests for platform-browser/animations + root cause analysis. It's the same bug that's making all the tests fail. We might have other bugs but we'll know more once we've fixed this one.

@ocombe ocombe requested a review from kara Dec 5, 2018

@googlebot googlebot added the cla: yes label Dec 5, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@kara

Looks good, but can you add a dummy test to bypass the "no specs" error? An alternative would be to keep the "fixme-aot" tags in the BUILD file, but I'm concerned we'll forget about them (much rather run an extra test by mistake).

// TODO: remove when removing fixmeIvy guards
it('should run a spec', () => {});

@ocombe ocombe removed their assignment Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@kara

kara approved these changes Dec 5, 2018

LGTM

@kara

This comment has been minimized.

Contributor

kara commented Dec 5, 2018

@IgorMinar Lacking animations approval permission for this one (missed it when adding to pullapprove.yml)

@IgorMinar IgorMinar closed this in b82f62a Dec 5, 2018

@ocombe ocombe deleted the ocombe:test/ivy/platform-browser/animations branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment