New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): update root causes for @angular/core TestBed failures #27479

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@pkozlowski-opensource
Member

pkozlowski-opensource commented Dec 5, 2018

No description provided.

@googlebot googlebot added the cla: yes label Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:ivy_root_causes_12_05 branch 2 times, most recently from 73cfdb8 to 0c14ac2 Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:ivy_root_causes_12_05 branch from 0c14ac2 to c714ee6 Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:ivy_root_causes_12_05 branch from c714ee6 to 795ba30 Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@mhevery

mhevery approved these changes Dec 5, 2018

@ngbot

This comment has been minimized.

ngbot bot commented Dec 5, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"
    pending forbidden labels detected: PR action: review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara

kara approved these changes Dec 5, 2018 edited

LGTM, just a typo or two. Looks like this needs a rebase too.

@@ -136,7 +136,7 @@ function declareTests(config?: {useJit: boolean}) {
expect(dir.text).toEqual('container');
});
fixmeIvy('unknown') &&
fixmeIvy('FW-795: Queries with descendants: true don\'t descent into <ng-container>') &&

This comment has been minimized.

@kara

kara Dec 5, 2018

Contributor
Suggested change Beta
fixmeIvy('FW-795: Queries with descendants: true don\'t descent into <ng-container>') &&
fixmeIvy('FW-795: Queries with descendants: true don\'t descend into <ng-container>') &&
});
// GH-2095 - https://github.com/angular/angular/issues/2095
// important as we are removing the ng-content element during compilation,
// which could skrew up text node indices.

This comment has been minimized.

@kara

kara Dec 5, 2018

Contributor

I know this isn't your typo, but it's driving me nuts:

Suggested change Beta
// which could skrew up text node indices.
// which could screw up text node indices.

@mhevery mhevery force-pushed the pkozlowski-opensource:ivy_root_causes_12_05 branch from 795ba30 to 40aa51a Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment