New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine #27482

Closed
wants to merge 2 commits into
base: master
from

Conversation

@marclaval
Member

marclaval commented Dec 5, 2018

Between Ivy and the View Engine, there are some discrepancies in the implementation of NgModuleRef which are causing 4 tests to fail in the router.
Currently in the View Engine:

  1. NgModuleRef is an Injector
  2. NgModuleRef has a public parent property named _public
  3. NgModuleRef has a dependency on CodegenComponentFactoryResolver which basically produces ComponentFactory which are bound to a module
@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@marclaval marclaval force-pushed the marclaval:lazyLoadedModule branch from 1b2ace1 to 39385d3 Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@marclaval marclaval changed the title from fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine to WIP: fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine Dec 5, 2018

@marclaval marclaval force-pushed the marclaval:lazyLoadedModule branch from 39385d3 to 950cc90 Dec 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 6, 2018

@marclaval marclaval changed the title from WIP: fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine to fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine Dec 6, 2018

@marclaval marclaval force-pushed the marclaval:lazyLoadedModule branch from 950cc90 to 9126038 Dec 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 6, 2018

@mhevery

mhevery approved these changes Dec 6, 2018

@mhevery

This comment has been minimized.

@mhevery mhevery self-assigned this Dec 6, 2018

@ngbot

This comment has been minimized.

ngbot bot commented Dec 6, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending forbidden labels detected: PR action: review
    pending status "code-review/pullapprove" is pending
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment