New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in #27484

wants to merge 1 commit into
base: master



bradbrandhorst commented Dec 5, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [ x] Documentation content changes
  • application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No period at the end of a sentence.

Issue Number: N/A

What is the new behavior?

A period at the end of a sentence.

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

Other information

docs: fix typo in
Added a period to the end of the last sentence in the first paragraph

This comment has been minimized.


brandonroberts commented Dec 6, 2018

Thanks for the PR @bradbrandhorst! Will you squash the commits down to a single commit with the original git commit message?

@bradbrandhorst bradbrandhorst force-pushed the bradbrandhorst:master branch from b1c8a85 to b7a0d87 Dec 6, 2018


This comment has been minimized.

bradbrandhorst commented Dec 6, 2018

@brandonroberts I think I did that correctly... let me know if I did it incorrectly, I'm just dipping my toes into contributing to OSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment