New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use buildifier binary release #27489

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@alexeagle
Contributor

alexeagle commented Dec 5, 2018

Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program

@googlebot googlebot added the cla: yes label Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@alexeagle alexeagle force-pushed the alexeagle:skylint branch 2 times, most recently from 3d3ba63 to e8427dc Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@alexeagle alexeagle force-pushed the alexeagle:skylint branch from e8427dc to 417e4f9 Dec 5, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 5, 2018

@kyliau kyliau assigned kyliau and unassigned kyliau Dec 5, 2018

alexeagle added some commits Dec 5, 2018

ci: use buildifier binary release
Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program

@alexeagle alexeagle force-pushed the alexeagle:skylint branch from 417e4f9 to f552501 Dec 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 6, 2018

@alexeagle alexeagle requested a review from IgorMinar Dec 6, 2018

alxhub added a commit that referenced this pull request Dec 7, 2018

ci: use buildifier binary release (#27489)
Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program

PR Close #27489

alxhub added a commit that referenced this pull request Dec 7, 2018

@alxhub alxhub closed this in cab5927 Dec 7, 2018

alxhub added a commit that referenced this pull request Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment