New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): fix "fixmeIvy" invocations in "platform-browser" tests #27498

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@AndrewKushnir
Contributor

AndrewKushnir commented Dec 6, 2018

Some "platform-browser" tests were updated before fixmeIvy function contract was changed to fixmeIvy(...).it(...), thus triggering failed tests to run on CI. This commit updates these cases to invoke fixmeIvy correctly.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)

Does this PR introduce a breaking change?

  • Yes
  • No
fix(ivy): fix fixmeIvy invocations in "platform-browser" tests
Some "platform-browser" tests were updated before `fixmeIvy` function contract was changed to `fixmeIvy(...).it(...)`, thus triggering failed tests to run on CI. This commit updates these cases to invoke `fixmeIvy` correctly.

@AndrewKushnir AndrewKushnir requested a review from IgorMinar Dec 6, 2018

@googlebot googlebot added the cla: yes label Dec 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 6, 2018

@IgorMinar

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment