New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): fix query compliance spec #27501

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kara
Contributor

kara commented Dec 6, 2018

This PR fixes the query compliance spec. It was broken because the ViewChildren import was missing, so the test never actually ran properly.

Will look into causing missing imports to throw to avoid this in the future.

@googlebot googlebot added the cla: yes label Dec 6, 2018

@kara kara requested a review from mhevery Dec 6, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 6, 2018

@mhevery

mhevery approved these changes Dec 6, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Dec 6, 2018

@ngbot

This comment has been minimized.

ngbot bot commented Dec 6, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "buildkite/angular" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara

This comment has been minimized.

Contributor

kara commented Dec 6, 2018

@IgorMinar The buildkite error doesn't look related to this change

@IgorMinar IgorMinar closed this in 160cace Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment