New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Get versions from latest-versions.ts & use semver check #27526

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@kyliau
Copy link
Member

kyliau commented Dec 7, 2018

When @angular/bazel is installed, a postinstall script is run to make sure that
the npm version is exactly the same as the Angular repository installed by
Bazel. This check is overly stringent. Instead, it should enforce that the
version satisfies the range check instead. This check is consistent with the range
defined in angular-cli/packages/schematics/angular/utility/latest-versions.ts.

This commit also fixes the Bazel workspace to use the same Rxjs version if it's
already installed.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from alexeagle Dec 7, 2018

@googlebot googlebot added the cla: yes label Dec 7, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 7, 2018

Show resolved Hide resolved packages/bazel/check_version.js Outdated
Show resolved Hide resolved packages/bazel/package.json
Show resolved Hide resolved packages/bazel/src/schematics/bazel-workspace/index_spec.ts Outdated
fix(bazel): Read latest versions from latest-versions.ts & use semver…
… check

When @angular/bazel is installed, a postinstall script is run to make sure that
the npm version is *exactly* the same as the Angular repository install by
Bazel. This check is overly stringent. Instead, it should enforce that the
version satisfies the range check instead. This is consistent with the range
defined in angular-cli/packages/schematics/angular/utility/latest-versions.ts.

This commit also fixes the Bazel workspace to use the same Rxjs version if it's
already installed.

@kyliau kyliau force-pushed the kyliau:versioncheck branch from 2a7cb1c to 28340d9 Dec 7, 2018

@kyliau kyliau changed the title fix(bazel): Read latest versions from latest-versions.ts & use semver check fix(bazel): Get versions from latest-versions.ts & use semver check Dec 7, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 7, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 7, 2018

@gregmagolan gregmagolan self-requested a review Dec 7, 2018

@gregmagolan
Copy link
Contributor

gregmagolan left a comment

LGTM

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Dec 10, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alxhub

This comment has been minimized.

Copy link
Contributor

alxhub commented Dec 11, 2018

@kyliau this failed to cherry-pick, @alexeagle told me to merge it to master only and someone would create a patch. Please check with him.

@alxhub alxhub closed this in 30a3b49 Dec 11, 2018

@kyliau kyliau deleted the kyliau:versioncheck branch Jan 22, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(bazel): Read latest versions from latest-versions.ts & use semver…
… check (angular#27526)

When @angular/bazel is installed, a postinstall script is run to make sure that
the npm version is *exactly* the same as the Angular repository install by
Bazel. This check is overly stringent. Instead, it should enforce that the
version satisfies the range check instead. This is consistent with the range
defined in angular-cli/packages/schematics/angular/utility/latest-versions.ts.

This commit also fixes the Bazel workspace to use the same Rxjs version if it's
already installed.

PR Close angular#27526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment