Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optionally save complete performance log in chrome benchpress tests #27551

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@treylitefm
Copy link
Contributor

treylitefm commented Dec 7, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

N/A

Issue Number: N/A

What is the new behavior?

If a RAW_PERFLOG_PATH is passed in as an option, benchpress saves chrome's performance log to a json file. This allows developers to download the json file and upload it to their browser to get a breakdown of chrome-side resource usage during a test.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Dec 7, 2018

@treylitefm treylitefm changed the title feat: optionally save complete performance log in chrome benchpress t… feat: optionally save complete performance log in chrome benchpress tests Dec 7, 2018

@treylitefm treylitefm force-pushed the treylitefm:benchpress-save-raw-performance-log branch from d0a82ed to 6583d1a Dec 7, 2018

@treylitefm treylitefm force-pushed the treylitefm:benchpress-save-raw-performance-log branch 2 times, most recently from 82d944b to 2775764 Jan 2, 2019

@vikerman vikerman requested a review from alxhub Jan 3, 2019

@alxhub

alxhub approved these changes Jan 16, 2019

Copy link
Contributor

alxhub left a comment

LGTM with the given suggestion, and another comment:

Please add a descriptive commit message, beyond just the commit title. The commit message should describe the feature being added and the motivation for it. It should be possible to look at the commit message and know what is happening and why.

@treylitefm treylitefm force-pushed the treylitefm:benchpress-save-raw-performance-log branch from 2775764 to 0b4eea1 Jan 16, 2019

@treylitefm treylitefm requested a review from angular/tools-benchpress as a code owner Jan 16, 2019

@treylitefm treylitefm force-pushed the treylitefm:benchpress-save-raw-performance-log branch 2 times, most recently from 5eefb8b to 084171e Jan 16, 2019

@treylitefm treylitefm force-pushed the treylitefm:benchpress-save-raw-performance-log branch 2 times, most recently from e2c7ee3 to 9b274b8 Jan 23, 2019

feat: optionally save complete performance log in chrome benchpress t…
…ests

If RAW_PERFLOG_PATH is passed in as an option, benchpress saves chrome's
performance log to a json file. This allows developers to download the
json file and upload it to their browser to get a breakdown of chrome-side
resource usage during a test.

@treylitefm treylitefm force-pushed the treylitefm:benchpress-save-raw-performance-log branch from 9b274b8 to b82b980 Jan 23, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 25, 2019

@matsko matsko closed this in d42f32c Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.