Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: optionally save complete performance log in chrome benchpress tests #27551
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
If a RAW_PERFLOG_PATH is passed in as an option, benchpress saves chrome's performance log to a json file. This allows developers to download the json file and upload it to their browser to get a breakdown of chrome-side resource usage during a test.
Does this PR introduce a breaking change?
changed the title
feat: optionally save complete performance log in chrome benchpress t…
Dec 7, 2018
Dec 7, 2018
2 times, most recently
Jan 2, 2019
alxhub left a comment
LGTM with the given suggestion, and another comment:
Please add a descriptive commit message, beyond just the commit title. The commit message should describe the feature being added and the motivation for it. It should be possible to look at the commit message and know what is happening and why.