Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Load http_archive and rules_nodejs dependencies #27609

Closed
wants to merge 1 commit into
base: master
from

Conversation

@kyliau
Copy link
Member

kyliau commented Dec 12, 2018

Bazel 0.20 requires loading http_archive explicitly.
rules_nodejs dependencies must now be installed explicity as well.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(bazel): Load http_archive and rules_nodejs dependencies
Bazel 0.20 requires loading http_archive explicitly.
rules_nodejs dependencies must now be installed explicity as well.

@kyliau kyliau requested a review from alexeagle Dec 12, 2018

@googlebot googlebot added the cla: yes label Dec 12, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 12, 2018

@kyliau kyliau removed the request for review from alexeagle Dec 12, 2018

@kyliau kyliau added the comp: bazel label Dec 12, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 12, 2018

@IgorMinar
Copy link
Member

IgorMinar left a comment

not sure why compiler-cli needs to approve. it seems wrong. I'll follow up on this.

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Dec 12, 2018

caretaker note: this change doesn't affect google3. I'm working on excluding this directory from the sync to resolve this confusion in the future.

@mhevery

This comment has been minimized.

mhevery added a commit that referenced this pull request Dec 13, 2018

fix(bazel): Load http_archive and rules_nodejs dependencies (#27609)
Bazel 0.20 requires loading http_archive explicitly.
rules_nodejs dependencies must now be installed explicity as well.

PR Close #27609

@mhevery mhevery closed this in 8313ffc Dec 13, 2018

@kyliau kyliau deleted the kyliau:http branch Jan 22, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(bazel): Load http_archive and rules_nodejs dependencies (angular#…
…27609)

Bazel 0.20 requires loading http_archive explicitly.
rules_nodejs dependencies must now be installed explicity as well.

PR Close angular#27609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.