Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): emit full node stack traces when Angular compilation crashes #27678

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@IgorMinar
Copy link
Member

IgorMinar commented Dec 14, 2018

The default 10 items are often not enough to debug deeply nested compilation operations.

fix(bazel): emit full node stack traces when Angular compilation crashes
The default 10 items are often not enough to debug deeply nested compilation operations.

This PR is based on @martinprobst's http://cl/225528216.

@IgorMinar IgorMinar force-pushed the IgorMinar:bazel/long-stack-traces branch from 1d46573 to ad3b623 Dec 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 14, 2018

@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Dec 14, 2018

caretaker note: this change was tested in the CL referenced. so no presubmit is needed.

@mhevery mhevery closed this in 522919a Dec 14, 2018

mhevery added a commit that referenced this pull request Dec 14, 2018

fix(bazel): emit full node stack traces when Angular compilation cras…
…hes (#27678)

The default 10 items are often not enough to debug deeply nested compilation operations.

This PR is based on @martinprobst's http://cl/225528216.

PR Close #27678

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(bazel): emit full node stack traces when Angular compilation cras…
…hes (angular#27678)

The default 10 items are often not enough to debug deeply nested compilation operations.

This PR is based on @martinprobst's http://cl/225528216.

PR Close angular#27678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.