Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add predicate function mode for runGuardsAndResolvers #27682

Closed
wants to merge 1 commit into
base: master
from

Conversation

@jasonaden
Copy link
Contributor

jasonaden commented Dec 14, 2018

This option means guards and resolvers will ignore changes when a provided predicate function returns false. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a project param might require re-run of guards and resolvers.

Related to #26861 #18253 #27464

@googlebot googlebot added the cla: yes label Dec 14, 2018

@jasonaden jasonaden requested a review from alxhub Dec 14, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 14, 2018

@googlebot googlebot added the cla: yes label Dec 14, 2018

@googlebot googlebot added the cla: yes label Dec 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 14, 2018

@jasonaden

This comment has been minimized.

Copy link
Contributor Author

jasonaden commented Dec 14, 2018

Show resolved Hide resolved packages/router/src/config.ts Outdated
Show resolved Hide resolved packages/router/src/config.ts Outdated
feat(router): add predicate function mode for runGuardsAndResolvers
This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers.

Related to #26861 #18253 #27464

@jasonaden jasonaden force-pushed the jasonaden:FW-824_predicate_shouldRunGuardsAndResolvers branch from 7085b30 to c001190 Dec 17, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 17, 2018

@alxhub

alxhub approved these changes Dec 18, 2018

@jasonaden jasonaden requested a review from IgorMinar Dec 18, 2018

@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 18, 2018

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Dec 18, 2018

caretaker note: pull approve doesn't approve

@mhevery mhevery closed this in 12c3176 Dec 18, 2018

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018

feat(router): add predicate function mode for runGuardsAndResolvers (a…
…ngular#27682)

This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers.

Related to angular#26861 angular#18253 angular#27464

PR Close angular#27682

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018

feat(router): add predicate function mode for runGuardsAndResolvers (a…
…ngular#27682)

This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers.

Related to angular#26861 angular#18253 angular#27464

PR Close angular#27682

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

feat(router): add predicate function mode for runGuardsAndResolvers (a…
…ngular#27682)

This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers.

Related to angular#26861 angular#18253 angular#27464

PR Close angular#27682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.