Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Set module_name and enable ng test #27715

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

kyliau commented Dec 17, 2018

Relative imports in Typescript files only work when module_name is
defined in ts_library (when run in Node.js).
See issue https://github.com/bazelbuild/rules_typescript/issues/360

With that fixed, ng test now works.

ng build requires node_modules to be available in the project
directory, so it's not usable yet. Running yarn in project directory
does not work because of postinstall version check.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Dec 17, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 17, 2018

@kyliau kyliau force-pushed the kyliau:bazel branch from 63e248d to 2b2e3b8 Dec 17, 2018

fix(bazel): Set module_name and enable ng test
Relative imports in Typescript files only work when module_name is
defined in ts_library (when run in Node.js).
See issue https://github.com/bazelbuild/rules_typescript/issues/360

With that fixed, `ng test` now works.

`ng build` requires `node_modules` to be available in the project
directory, so it's not usable yet. Running `yarn` in project directory
does not work because of postinstall version check.

@kyliau kyliau force-pushed the kyliau:bazel branch from 2b2e3b8 to 0256698 Dec 17, 2018

@kyliau kyliau added the comp: bazel label Dec 17, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 17, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 17, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 17, 2018

@kyliau kyliau requested a review from alexeagle Dec 17, 2018

@mhevery mhevery closed this in 85866de Dec 18, 2018

mhevery added a commit that referenced this pull request Dec 18, 2018

fix(bazel): Set module_name and enable ng test (#27715)
Relative imports in Typescript files only work when module_name is
defined in ts_library (when run in Node.js).
See issue https://github.com/bazelbuild/rules_typescript/issues/360

With that fixed, `ng test` now works.

`ng build` requires `node_modules` to be available in the project
directory, so it's not usable yet. Running `yarn` in project directory
does not work because of postinstall version check.

PR Close #27715

@kyliau kyliau deleted the kyliau:bazel branch Jan 15, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(bazel): Set module_name and enable ng test (angular#27715)
Relative imports in Typescript files only work when module_name is
defined in ts_library (when run in Node.js).
See issue https://github.com/bazelbuild/rules_typescript/issues/360

With that fixed, `ng test` now works.

`ng build` requires `node_modules` to be available in the project
directory, so it's not usable yet. Running `yarn` in project directory
does not work because of postinstall version check.

PR Close angular#27715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.