Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): devserver entry_module should have underscore name #27719

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

kyliau commented Dec 18, 2018

This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from mgechev Dec 18, 2018

@googlebot googlebot added the cla: yes label Dec 18, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 18, 2018

@kyliau kyliau force-pushed the kyliau:bazel_bugfix branch from 35eb39f to 91352ce Dec 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 18, 2018

@kyliau kyliau force-pushed the kyliau:bazel_bugfix branch from 91352ce to 9679da5 Dec 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 18, 2018

fix(bazel): devserver entry_module should have underscore name
This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

@kyliau kyliau force-pushed the kyliau:bazel_bugfix branch from 9679da5 to 966042d Dec 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 18, 2018

@mhevery mhevery closed this in f57916c Dec 18, 2018

mhevery added a commit that referenced this pull request Dec 18, 2018

fix(bazel): devserver entry_module should have underscore name (#27719)
This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Close #27719

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018

fix(bazel): devserver entry_module should have underscore name (angul…
…ar#27719)

This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Close angular#27719

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018

fix(bazel): devserver entry_module should have underscore name (angul…
…ar#27719)

This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Close angular#27719

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 22, 2018

test(bazel): fix `bazel-workspace` schematics test
The test was cherry-picked from angular#27719 into 7.1.x, where entry module
path ended in `/main`, not `/main.dev`. It was changed to `/main.dev`
in angular#27277, which was not backported to 7.1.x.

matsko added a commit that referenced this pull request Dec 25, 2018

test(bazel): fix `bazel-workspace` schematics test
The test was cherry-picked from #27719 into 7.1.x, where entry module
path ended in `/main`, not `/main.dev`. It was changed to `/main.dev`
in #27277, which was not backported to 7.1.x.

@kyliau kyliau deleted the kyliau:bazel_bugfix branch Jan 15, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(bazel): devserver entry_module should have underscore name (angul…
…ar#27719)

This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Close angular#27719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.