Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use image based cache for windows BuildKite #27990

Closed

Conversation

Projects
None yet
5 participants
@filipesilva
Copy link
Member

filipesilva commented Jan 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested a review from angular/fw-dev-infra as a code owner Jan 8, 2019

@googlebot googlebot added the cla: yes label Jan 8, 2019

@filipesilva filipesilva force-pushed the filipesilva:buildkite-docker-cache branch 6 times, most recently from 5b8ad7d to 1f8bc1b Jan 8, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 8, 2019

@filipesilva filipesilva force-pushed the filipesilva:buildkite-docker-cache branch from 1f8bc1b to a482b72 Jan 8, 2019

@filipesilva filipesilva requested a review from gkalpak Jan 8, 2019

@gkalpak

gkalpak approved these changes Jan 9, 2019

Copy link
Member

gkalpak left a comment

Looks reasonable (afaict 😁)

@@ -0,0 +1,20 @@
# Use the a previous image as source.
FROM gcr.io/internal-200822/angular-windows:master

This comment has been minimized.

Copy link
@gkalpak

gkalpak Jan 9, 2019

Member

Where does internal-200822 come from? Would be a good idea to add a comment for future reference.

This comment has been minimized.

Copy link
@filipesilva

filipesilva Jan 9, 2019

Author Member

It is our internal google cloud project where the machines are. Will mention that.

@@ -0,0 +1,32 @@
ARG target=node:10.12

This comment has been minimized.

Copy link
@gkalpak

gkalpak Jan 9, 2019

Member

Where is this file used?

This comment has been minimized.

Copy link
@filipesilva

filipesilva Jan 9, 2019

Author Member

Nowhere, it was a bad rebase. Good catch, removing it!

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Jan 9, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alexeagle

This comment has been minimized.

Copy link
Contributor

alexeagle commented Jan 9, 2019

caretaker: known failures of legacy-unit-tests-saucelabs see #caretaker

@filipesilva filipesilva deleted the filipesilva:buildkite-docker-cache branch Jan 14, 2019

filipesilva added a commit to filipesilva/angular that referenced this pull request Jan 14, 2019

ci: build clean windows cache image on master
Shortly after angular#27990 the Windows CI started failing with `Service 'windows-test' failed to build: max depth exceeded`.

Looking up this error shows that docker images have a maximum of 127 layers. The current setup adds more and more layers over time, reaching this limit.

This PR addresses the problem by always creating the cache image clean base environment, without reusing the previous one. This only happens on master.

Related to angular#27508

filipesilva added a commit to filipesilva/angular that referenced this pull request Jan 14, 2019

ci: build clean windows cache image on master
Shortly after angular#27990 the Windows CI started failing with `Service 'windows-test' failed to build: max depth exceeded`.

Looking up this error shows that docker images have a maximum of 127 layers. The current setup adds more and more layers over time, reaching this limit.

This PR addresses the problem by always creating the cache image clean base environment, without reusing the previous one. This only happens on master.

Related to angular#27508

filipesilva added a commit to filipesilva/angular that referenced this pull request Jan 15, 2019

alxhub added a commit that referenced this pull request Jan 18, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.