New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc test cleanup #28035

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@kara
Copy link
Contributor

kara commented Jan 10, 2019

We missed a few tests in #28014. Looked into the remaining tests and they seem to have the same root cause as the others.

@kara kara requested a review from angular/fw-router as a code owner Jan 10, 2019

@ngbot ngbot bot modified the milestone: needsTriage Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

@kara kara requested review from mhevery and IgorMinar Jan 10, 2019

@kara kara requested a review from angular/fw-core as a code owner Jan 10, 2019

@kara kara changed the title test(ivy): diagnose root causes of remaining failing router tests Misc test cleanup Jan 10, 2019

@AndrewKushnir
Copy link
Contributor

AndrewKushnir left a comment

LGTM!

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

@kara kara removed request for angular/fw-router and IgorMinar Jan 10, 2019

AndrewKushnir added a commit that referenced this pull request Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment