New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: onlyInIvy tests should not be triggered for FIND_PASSING_TESTS mode #28036

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kara
Copy link
Contributor

kara commented Jan 10, 2019

Previous to this change, there was a lot of noise when
trying to find tests in FIND_PASSING_TESTS mode because
tests marked "onlyInIvy" were also listed as "already
passing". Since these tests are not "fixmes" that need
to be enabled, it is not useful to have them listed.

This commit removes "onlyInIvy" tests from consideration
when running in this manual mode. The tests should still
run on CI by default (since FIND_PASSING_TESTS mode will
be false).

ci: onlyInIvy tests should not be triggered for FIND_PASSING_TESTS mode
Previous to this change, there was a lot of noise when
trying to find tests in FIND_PASSING_TESTS mode because
tests marked "onlyInIvy" were also listed as "already
passing". Since these tests are not "fixmes" that need
to be enabled, it is not useful to have them listed.

This commit removes "onlyInIvy" tests from consideration
when running in this manual mode. The tests should still
run on CI by default (since FIND_PASSING_TESTS mode will
be false).

@kara kara requested a review from IgorMinar as a code owner Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@kara kara requested a review from mhevery Jan 10, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 10, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

@kara kara removed the PR action: review label Jan 10, 2019

@kara kara removed the request for review from IgorMinar Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment