New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): fix typo #28042

Closed
wants to merge 1 commit into
base: master
from

Conversation

@ernest-galbrun
Copy link
Contributor

ernest-galbrun commented Jan 10, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts

This comment has been minimized.

Copy link
Contributor

brandonroberts commented Jan 14, 2019

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 15, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 15, 2019

@brandonroberts I've rebased this PR on top of the latest master and run g3 presubmit to verify everything looks good. Could you please have a quick look at the changes to make sure there are no unexpected changes after rebase and return "merge" label back if everything is ok? Thank you.

@brandonroberts

This comment has been minimized.

Copy link
Contributor

brandonroberts commented Jan 15, 2019

LGTM

AndrewKushnir added a commit that referenced this pull request Jan 15, 2019

AndrewKushnir added a commit that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment