New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(upgrade): log more info to help debug CI flakes #28045

Closed
wants to merge 1 commit into
base: master
from

Conversation

@gkalpak
Copy link
Member

gkalpak commented Jan 10, 2019

Related Jira issue: FW-939

@gkalpak gkalpak requested a review from angular/fw-upgrade as a code owner Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 10, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

@@ -22,19 +22,30 @@ import {compileFactory, injectorFactory, parseFactory, rootScopeFactory, setTemp

describe('injectorFactory', () => {
it('should return the injector value that was previously set', () => {
const mockInjector = {get: () => {}, has: () => false};
const mockInjector = {get: () => undefined, has: () => false};

This comment has been minimized.

@petebacondarwin

petebacondarwin Jan 10, 2019

Member

what difference does this change make?

This comment has been minimized.

@gkalpak

gkalpak Jan 10, 2019

Member

Nothing 😁 (It's just considered good practice.)

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 10, 2019

AndrewKushnir added a commit that referenced this pull request Jan 10, 2019

@gkalpak gkalpak deleted the gkalpak:test-upgrade-debug-flake branch Jan 10, 2019

AndrewKushnir added a commit that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment