New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two @nocollapse related fixes for Ivy #28050

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@alxhub
Copy link
Contributor

alxhub commented Jan 10, 2019

No description provided.

fix(ivy): ensure @nocollapse is added to static fields
ngtsc has a hack to add @nocollapse jsdoc annotations to generated static
fields. This hack is currently broken (likely due to a TypeScript change
in the way writeFile() works).

This commit fixes the hack and introduces an ngtsc_spec test to ensure it
does not regress again.

@alxhub alxhub requested a review from angular/fw-compiler as a code owner Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@alxhub alxhub requested a review from vikerman Jan 10, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

fix(ivy): add missing @nocollapse annotation to __NG_ELEMENT_ID__ fields
__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector
works. In order to survive closure minification correctly, they need to
be annotated with @nocollapse.

@alxhub alxhub requested a review from angular/fw-core as a code owner Jan 10, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

@alxhub alxhub requested a review from AndrewKushnir Jan 10, 2019

@alxhub alxhub changed the title fix(ivy): ensure @nocollapse is added to static fields Two @nocollapse related fixes for Ivy Jan 10, 2019

@AndrewKushnir
Copy link
Contributor

AndrewKushnir left a comment

LGTM!

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 11, 2019

@vikerman @alxhub could you plz post g3 presubmit link or change g3 status? Thank you.

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 11, 2019

AndrewKushnir added a commit that referenced this pull request Jan 11, 2019

fix(ivy): add missing @nocollapse annotation to __NG_ELEMENT_ID__ fie…
…lds (#28050)

__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector
works. In order to survive closure minification correctly, they need to
be annotated with @nocollapse.

PR Close #28050

kyliau added a commit to kyliau/angular that referenced this pull request Jan 11, 2019

fix(ivy): ensure @nocollapse is added to static fields (angular#28050)
ngtsc has a hack to add @nocollapse jsdoc annotations to generated static
fields. This hack is currently broken (likely due to a TypeScript change
in the way writeFile() works).

This commit fixes the hack and introduces an ngtsc_spec test to ensure it
does not regress again.

PR Close angular#28050

kyliau added a commit to kyliau/angular that referenced this pull request Jan 11, 2019

fix(ivy): add missing @nocollapse annotation to __NG_ELEMENT_ID__ fie…
…lds (angular#28050)

__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector
works. In order to survive closure minification correctly, they need to
be annotated with @nocollapse.

PR Close angular#28050

mhevery added a commit to mhevery/angular that referenced this pull request Jan 12, 2019

AndrewKushnir added a commit that referenced this pull request Jan 12, 2019

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

fix(ivy): ensure @nocollapse is added to static fields (angular#28050)
ngtsc has a hack to add @nocollapse jsdoc annotations to generated static
fields. This hack is currently broken (likely due to a TypeScript change
in the way writeFile() works).

This commit fixes the hack and introduces an ngtsc_spec test to ensure it
does not regress again.

PR Close angular#28050

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

fix(ivy): add missing @nocollapse annotation to __NG_ELEMENT_ID__ fie…
…lds (angular#28050)

__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector
works. In order to survive closure minification correctly, they need to
be annotated with @nocollapse.

PR Close angular#28050

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

fix(ivy): ensure @nocollapse is added to static fields (angular#28050)
ngtsc has a hack to add @nocollapse jsdoc annotations to generated static
fields. This hack is currently broken (likely due to a TypeScript change
in the way writeFile() works).

This commit fixes the hack and introduces an ngtsc_spec test to ensure it
does not regress again.

PR Close angular#28050

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

fix(ivy): add missing @nocollapse annotation to __NG_ELEMENT_ID__ fie…
…lds (angular#28050)

__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector
works. In order to survive closure minification correctly, they need to
be annotated with @nocollapse.

PR Close angular#28050

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

fix(ivy): ensure @nocollapse is added to static fields (angular#28050)
ngtsc has a hack to add @nocollapse jsdoc annotations to generated static
fields. This hack is currently broken (likely due to a TypeScript change
in the way writeFile() works).

This commit fixes the hack and introduces an ngtsc_spec test to ensure it
does not regress again.

PR Close angular#28050

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

fix(ivy): add missing @nocollapse annotation to __NG_ELEMENT_ID__ fie…
…lds (angular#28050)

__NG_ELEMENT_ID__ static fields are a part of how the Ivy node injector
works. In order to survive closure minification correctly, they need to
be annotated with @nocollapse.

PR Close angular#28050

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment