New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Angular CLI version used in ng_rollup_bundle #28052

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@filipesilva
Copy link
Member

filipesilva commented Jan 10, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested review from angular/fw-dev-infra as code owners Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 10, 2019

@kyliau

kyliau approved these changes Jan 11, 2019

@kyliau

This comment has been minimized.

Copy link
Member

kyliau commented Jan 11, 2019

@filipesilva I have a JIRA ticket to remove angular-cli from angular repo entirely, but I haven't got any success so far. I think we've come to the conclusion that cross workspace repos are not ideal, mainly because there is no way to distinguish the dependencies of one repo from another. i.e. as seen from the CI failures above, angular-cli repo run yarn_install in npm whereas angular repo runs it in ngdeps.

@filipesilva

This comment has been minimized.

Copy link
Member

filipesilva commented Jan 11, 2019

Yeah these dependencies are very much not ideal. I'm not sure how to work around this dependency issue. The best I can come up with is moving ng_rollup_bundle to another repo.

@alexeagle @gregmagolan WDYT?

build: use build optimizer from node_modules in ng_rollup_bundle
ng_rollup_bundle had a Bazel dependency on the Angular CLI repository.

Updating this dependency is hard because one must also include the transitive
node dependencies of the Angular CLI repository.

That the Angular repository uses `@ngdeps` as its node dependency label
instead of `@npm` as is the default name further complicates updates.

Since the only package needed from Angular CLI is @angular-devkit/build-optimizer,
we can instead import the compiled package.

@filipesilva filipesilva force-pushed the filipesilva:bazel-update-cli branch from d80a858 to c327d74 Jan 11, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment