New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): ignore empty bindings #28059

Closed
wants to merge 2 commits into
base: master
from

Conversation

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jan 11, 2019

This update aligns Ivy behavior with ViewEngine related to empty bindings (for example <div [someProp]>): empty bindings are ignored.

As a part of this PR I also removed this TODO (since I had to move some code): TODO(chuckj): runtime: security context. It looks like this TODO is obsolete, since we have sanitization mechanisms invoked at runtime as needed.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
fix(ivy): ignore empty bindings
This update aligns Ivy behavior with ViewEngine related to empty bindings (for example <div [someProp]></div>): empty bindings are ignored.
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 11, 2019

@kara

kara approved these changes Jan 11, 2019

Copy link
Contributor

kara left a comment

LGTM

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 11, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 11, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Jan 11, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 11, 2019

kyliau added a commit to kyliau/angular that referenced this pull request Jan 11, 2019

fix(ivy): ignore empty bindings (angular#28059)
This update aligns Ivy behavior with ViewEngine related to empty bindings (for example <div [someProp]></div>): empty bindings are ignored.

PR Close angular#28059

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

fix(ivy): ignore empty bindings (angular#28059)
This update aligns Ivy behavior with ViewEngine related to empty bindings (for example <div [someProp]></div>): empty bindings are ignored.

PR Close angular#28059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment