New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bazel): Use local_repository to load Angular #28061

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

kyliau commented Jan 11, 2019

The current integration test for Bazel schematics downloads a
published version of Angular as required by the http_archive
rule in the CLI created WORKSPACE.
However, this makes the test less useful because it does not
actually test any changes to the Angular repo at source.
This PR replaces the http_archive method in the WORSPACE
with local_repository so that any local changes to the Angular
repo are tested accordingly.

With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI
no longer compiles under Bazel due to missing type annotations.
A temporary file is placed in the integration/bazel-schematics
directory while the change is pending in CLI repo.
https://github.com/angular/angular-cli/pull/13406

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/fw-integration as a code owner Jan 11, 2019

@googlebot googlebot added the cla: yes label Jan 11, 2019

@kyliau kyliau force-pushed the kyliau:local_angular branch 2 times, most recently from 52211eb to e5a1a3e Jan 11, 2019

@kyliau kyliau requested a review from angular/fw-dev-infra as a code owner Jan 11, 2019

@kyliau kyliau force-pushed the kyliau:local_angular branch 4 times, most recently from cd6b13c to e758b5d Jan 11, 2019

@kyliau kyliau removed the PR state: WIP label Jan 11, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 11, 2019

@kyliau kyliau referenced this pull request Jan 11, 2019

Closed

refactor(bazel): use web_package rule for index.html #27995

4 of 14 tasks complete
test(bazel): Use local_repository to load Angular
The current integration test for Bazel schematics downloads a
published version of Angular as required by the http_archive
rule in the CLI created WORKSPACE.
However, this makes the test less useful because it does not
actually test any changes to the Angular repo at source.
This PR replaces the http_archive method in the WORSPACE
with local_repository so that any local changes to the Angular
repo are tested accordingly.

With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI
no longer compiles under Bazel due to missing type annotations.
A temporary file is placed in the integration/bazel-schematics
directory while the change is pending in CLI repo.
angular/angular-cli#13406

@kyliau kyliau force-pushed the kyliau:local_angular branch from e758b5d to e42f107 Jan 11, 2019

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019

test(bazel): Use local_repository to load Angular (angular#28061)
The current integration test for Bazel schematics downloads a
published version of Angular as required by the http_archive
rule in the CLI created WORKSPACE.
However, this makes the test less useful because it does not
actually test any changes to the Angular repo at source.
This PR replaces the http_archive method in the WORSPACE
with local_repository so that any local changes to the Angular
repo are tested accordingly.

With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI
no longer compiles under Bazel due to missing type annotations.
A temporary file is placed in the integration/bazel-schematics
directory while the change is pending in CLI repo.
angular/angular-cli#13406

PR Close angular#28061

@gkalpak gkalpak referenced this pull request Jan 17, 2019

Open

feat(ivy): implement listing lazy routes in `ngtsc` #27697

5 of 7 tasks complete

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

test(bazel): Use local_repository to load Angular (angular#28061)
The current integration test for Bazel schematics downloads a
published version of Angular as required by the http_archive
rule in the CLI created WORKSPACE.
However, this makes the test less useful because it does not
actually test any changes to the Angular repo at source.
This PR replaces the http_archive method in the WORSPACE
with local_repository so that any local changes to the Angular
repo are tested accordingly.

With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI
no longer compiles under Bazel due to missing type annotations.
A temporary file is placed in the integration/bazel-schematics
directory while the change is pending in CLI repo.
angular/angular-cli#13406

PR Close angular#28061

wKoza added a commit to wKoza/angular that referenced this pull request Jan 18, 2019

test(bazel): Use local_repository to load Angular (angular#28061)
The current integration test for Bazel schematics downloads a
published version of Angular as required by the http_archive
rule in the CLI created WORKSPACE.
However, this makes the test less useful because it does not
actually test any changes to the Angular repo at source.
This PR replaces the http_archive method in the WORSPACE
with local_repository so that any local changes to the Angular
repo are tested accordingly.

With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI
no longer compiles under Bazel due to missing type annotations.
A temporary file is placed in the integration/bazel-schematics
directory while the change is pending in CLI repo.
angular/angular-cli#13406

PR Close angular#28061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment