Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(ivy): deps are actually supported #28076
This code was throwing if the
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Quoting @alxhub on Slack (back in November when I first spotted the issue):
What is the new behavior?
Does this PR introduce a breaking change?
I added a bunch of tests because there was none for:
@cexbrayat I've run tests in Google codebase and faced some issues. The problems are most likely cause by the fact that this PR was created on top of master while it was in broken state. Could you please rebase it based on the most up-to-date version of master and send a comment here? I'll run Google tests again to see if that resolves the problem. Thank you.