Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: remove deprecated DOCUMENT token from platform-browser #28117
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
2 times, most recently
Jan 13, 2019
@alfaproject Yeah I don't know. It's literally the opposite of a
I expect that this will break a significant amount of code at google. I'm running a presubmit now to verify the impact.
If confirmed, we might need to create a ts-lint refactoring transform to make this change automatically and roll this out as part of
@StephenFluin can we get a reliable estimate of this change on external users? I'm quite sure it's significant and therefore we could roll this out only with automated refactoring of apps and libraries (which in this case is safe and relatively straightforward).
internal presubmit results: http://test/OCL:229126105:BASE:229126324:1547447183003:cc4ee4a9
preliminary results: there is a handful of apps that still work after this change, but great majority of apps in google3 are broken.
Now in order to make the transform compatible with
We then write a
changed the title
refactor: remove deprecated DOCUMENT token from platform-browser
Jan 14, 2019
Around 80% of apps I just scanned use the
I wouldn't have guessed that it would be many people, as I would guess most developers access