Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build clean windows cache image on master #28131

Closed

Conversation

Projects
None yet
3 participants
@filipesilva
Copy link
Member

commented Jan 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Shortly after #27990 the Windows CI started failing with Service 'windows-test' failed to build: max depth exceeded.

Looking up this error shows that docker images have a maximum of 127 layers. The current setup adds more and more layers over time, reaching this limit.

This PR addresses the problem by always creating the cache image clean base environment, without reusing the previous one. This only happens on master.

Related to #27508

What is the new behavior?

Cache image will only have a limited number of layers.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ci: build clean windows cache image on master
Shortly after #27990 the Windows CI started failing with `Service 'windows-test' failed to build: max depth exceeded`.

Looking up this error shows that docker images have a maximum of 127 layers. The current setup adds more and more layers over time, reaching this limit.

This PR addresses the problem by always creating the cache image clean base environment, without reusing the previous one. This only happens on master.

Related to #27508

@filipesilva filipesilva requested a review from gkalpak Jan 14, 2019

@filipesilva filipesilva requested a review from angular/fw-dev-infra as a code owner Jan 14, 2019

@googlebot googlebot added the cla: yes label Jan 14, 2019

@filipesilva

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Superseded by #28160.

@filipesilva filipesilva deleted the filipesilva:master-clean-cache-image branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.