Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "ci: use image based cache for windows BuildKite (#27990)" #28160

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@filipesilva
Copy link
Member

filipesilva commented Jan 15, 2019

This reverts commit eb1aae4.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Shortly after #27990 the Windows CI started failing with Service 'windows-test' failed to build: max depth exceeded.

I looked at ways to address that in #28131, but eventually figured out that building a docker image with cached state for angular/angular would always take around 1h.

The core problem is related to creation of files in Windows Docker containers and is reported in docker/for-win#3229.

This PR reverts #27990 and restores the previous setup.

What is the new behavior?

Previous buildkite/docker setup is restored.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested a review from gkalpak Jan 15, 2019

@filipesilva filipesilva requested a review from angular/fw-dev-infra as a code owner Jan 15, 2019

@googlebot googlebot added the cla: yes label Jan 15, 2019

@gkalpak
Copy link
Member

gkalpak left a comment

😞

@alxhub alxhub closed this in 7bdf3fe Jan 18, 2019

@filipesilva filipesilva deleted the filipesilva:revert-docker-cache branch Jan 22, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.