Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): Add support for SASS #28167

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@kyliau
Copy link
Member

commented Jan 15, 2019

This commit adds the appropriate rules to the WORKSPACE for a project
that requires SASS support.

Followup PR: Add .scss files to bazel-schematics integration test.
The work is pending #28166 to be merged.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

feat(bazel): Add support for SASS
This commit adds the appropriate rules to the WORKSPACE for a project
that requires SASS support.

@kyliau kyliau requested a review from mgechev Jan 15, 2019

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Jan 15, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 15, 2019

@googlebot googlebot added the cla: yes label Jan 15, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Jan 15, 2019

@alexeagle
Copy link
Contributor

left a comment

I think we ought to land it together with the corresponding tests

assets = glob([
"**/*.css",
"**/*.html",
]) + [":style_" + x for x in glob(["**/*.scss"])],`);

This comment has been minimized.

Copy link
@alexeagle

alexeagle Jan 16, 2019

Contributor

nit: this assertion is too brittle, or the test is too fake.

If you just want to check that the conditional logic for turning on and including the sass content is working, it's sufficient to just assert that it contains **/*.scss
If you want to check that this list comprehension works, then the test needs to at least run a bazel query on the file so that we evaluate the expression

the way it is, many changes to the production code will require test maintenance just to copy across the new string, and the test doesn't check if those changes are correct.

@alxhub alxhub closed this in f59f18c Jan 17, 2019

alxhub added a commit that referenced this pull request Jan 17, 2019

feat(bazel): Add support for SASS (#28167)
This commit adds the appropriate rules to the WORKSPACE for a project
that requires SASS support.

PR Close #28167

@alexeagle alexeagle referenced this pull request Jan 17, 2019

Open

Porting to Bazel #63

4 of 10 tasks complete

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

feat(bazel): Add support for SASS (angular#28167)
This commit adds the appropriate rules to the WORKSPACE for a project
that requires SASS support.

PR Close angular#28167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.