Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): ng-new should run yarn install #28381

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

commented Jan 25, 2019

yarn install was disabled in ng-new for Bazel schematics because
Bazel manages its own node_modules dependencies and therefore
there is no need to install dependencies twice.

However, the first yarn install is needed for ng commands to work,
most notably ng build.

This commit restores the original behavior.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(bazel): ng-new should run yarn install
yarn install was disabled in ng-new for Bazel schematics because
Bazel manages its own node_modules dependencies and therefore
there is no need to install dependencies twice.

However, the first yarn install is needed for `ng` commands to work,
most notably `ng build`.

This commit restores the original behavior.

@kyliau kyliau requested review from angular/fw-integration as code owners Jan 25, 2019

@googlebot googlebot added the cla: yes label Jan 25, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 25, 2019

@kyliau kyliau requested a review from alexeagle Jan 26, 2019

@kyliau kyliau removed the PR state: WIP label Jan 28, 2019

jasonaden added a commit that referenced this pull request Jan 28, 2019

fix(bazel): ng-new should run yarn install (#28381)
yarn install was disabled in ng-new for Bazel schematics because
Bazel manages its own node_modules dependencies and therefore
there is no need to install dependencies twice.

However, the first yarn install is needed for `ng` commands to work,
most notably `ng build`.

This commit restores the original behavior.

PR Close #28381

@jasonaden jasonaden closed this in 3b48d13 Jan 28, 2019

vetom added a commit to vetom/angular that referenced this pull request Jan 31, 2019

fix(bazel): ng-new should run yarn install (angular#28381)
yarn install was disabled in ng-new for Bazel schematics because
Bazel manages its own node_modules dependencies and therefore
there is no need to install dependencies twice.

However, the first yarn install is needed for `ng` commands to work,
most notably `ng build`.

This commit restores the original behavior.

PR Close angular#28381

@kyliau kyliau deleted the kyliau:install branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.