Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: pngcrush all pngs #28479

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@jelbourn
Copy link
Member

jelbourn commented Jan 31, 2019

This is the result of running

find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;

Summary of size reductions

Last done in July, 2017 in #18243

perf: pngcrush all pngs
This is the result of running
```sh
find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;
```

[Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview)

Last done in July, 2017 in #18243

@jelbourn jelbourn requested review from IgorMinar and angular/docs-infra as code owners Jan 31, 2019

@googlebot googlebot added the cla: yes label Jan 31, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 31, 2019

@StephenFluin

This comment has been minimized.

Copy link
Member

StephenFluin commented Jan 31, 2019

@jelbourn Any reason not to use pngquant instead? I've found pngquant to be a superior compression as it is lossy.

@andrewseguin
Copy link
Contributor

andrewseguin left a comment

LGTM (at least for Elements)

@gkalpak gkalpak referenced this pull request Jan 31, 2019

Closed

add Keilla Fernandes to GDE resources #28437

3 of 14 tasks complete
@jelbourn

This comment has been minimized.

Copy link
Member Author

jelbourn commented Jan 31, 2019

@StephenFluin never heard of it before. I'll try that when I do this again in 2021.

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Jan 31, 2019

merge-assistance: please accept my global approval for this PR and get it in before it goes stale. thank you!

@matsko

matsko approved these changes Feb 1, 2019

@matsko matsko closed this in ec6e730 Feb 1, 2019

matsko added a commit that referenced this pull request Feb 1, 2019

perf: pngcrush all pngs (#28479)
This is the result of running
```sh
find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;
```

[Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview)

Last done in July, 2017 in #18243

PR Close #28479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.