refactor(compiler): allow disabling external symbol factory reexports #28594
refactor(compiler): allow disabling external symbol factory reexports
Currently external static symbols which are referenced by AOT compiler generated code, will be re-exported in the corresponding `.ngfactory` files. This way of handling the symbol resolution has been introduced in favor of avoding dynamically generated module dependencies. This behavior therefore avoids any strict dependency failures. Read more about a particular scenario here: #25644 (comment) Now with `ngtsc`, this behavior has changed since `ngtsc` just introduces these module dependencies in order to properly reference the external symbol from its original location (also eliminating the need for factories). Similarly we should provide a way to use the same behavior with `ngc` because the downside of using the re-exported symbol resolution is that user-code transformations (e.g. the `ngInjectableDef` metadata which is added to the user source code), can resolve external symbols to previous factory symbol re-exports. This is a critical issue because it means that the actual JIT code references factory files in order to access external symbols. This means that the generated output cannot shipped to NPM without shipping the referenced factory files. A specific example has been reported here: #25644 (comment)
- Loading branch information...
ProTip! Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.