Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade domino to v2.1.2 #28767

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@CaerusKaru
Copy link
Member

commented Feb 15, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru CaerusKaru requested a review from angular/fw-dev-infra as a code owner Feb 15, 2019

@googlebot googlebot added the cla: yes label Feb 15, 2019

@CaerusKaru

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

@mhevery mhevery closed this in fdca001 Feb 17, 2019

@IgorMinar

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

shouldn't we also update the dep in platform-server:

@CaerusKaru CaerusKaru deleted the CaerusKaru:adam/domino212 branch Feb 24, 2019

@CaerusKaru

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

@IgorMinar At the time I didn't think it was necessary since a fresh install would bump the dep anyway. But @clydin made a PR for it here: #28893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.