test(bazel): Upgrade CLI dependencies for schematics test #28872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
target: major
alexeagle
approved these changes
Feb 20, 2019
| @@ -1,7 +1,19 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -eux -o pipefail | |||
| readonly pwd=$(pwd) | |||
|
|
|||
| function installLocalPackages() { | |||
There was a problem hiding this comment.
comment that this is a workaround for yarn caching the file:// urls otherwise
Workaround yarnpkg/yarn#2165
This commit makes the integration test for bazel-schematics more robust by removing package.json.replace. Instead of replacing the file, the test script now just overrides Angular packages with the local ones. This commit also fixes running the test locally by providing default argument for CI_CHROMEDRIVER_VERSION_ARG.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the integration test for bazel-schematics more robust
by removing package.json.replace. Instead of replacing the file, the
test script now just overrides Angular packages with the local ones.
This commit also fixes running the test locally by providing default
argument for CI_CHROMEDRIVER_VERSION_ARG.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information