Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): api extractor don't generate tsdoc metadata #29023

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@alan-agius4
Copy link
Contributor

alan-agius4 commented Feb 28, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Tsdoc metadata is generated but not used.

What is the new behaviour

tsdoc metadata is not needed for ng_module and with @microsoft/api-extractor version 7.0.21 there is a new flag to disable it's generation.

See: Microsoft/web-build-tools#1051

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 requested review from angular/fw-dev-infra as code owners Feb 28, 2019

@googlebot googlebot added the cla: yes label Feb 28, 2019

@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

alan-agius4 commented Feb 28, 2019

//cc @alexeagle

@alan-agius4 alan-agius4 force-pushed the alan-agius4:api-extractor-tsdoc branch from dc1b08f to 50dd83b Mar 1, 2019

@alan-agius4 alan-agius4 changed the title fix(bazel): ng_module don't generate tsdoc metadata fix(bazel): api extractor don't generate tsdoc metadata Mar 1, 2019

fix(bazel): api extractor don't generate tsdoc metadata
tsdoc metadata is not needed for `ng_module` and with `@microsoft/api-extractor` version 7.0.21 there is a new flag to disable it's generation.

See: Microsoft/web-build-tools#1051

@alan-agius4 alan-agius4 force-pushed the alan-agius4:api-extractor-tsdoc branch from 50dd83b to 0ba50fd Mar 1, 2019

@@ -89,6 +89,9 @@ export function runMain(
enabled: !!dtsBundleOut,
publishFolder: dtsBundleOut && path.resolve(path.dirname(dtsBundleOut)),
mainDtsRollupPath: dtsBundleOut && path.basename(dtsBundleOut),
},
tsdocMetadata: {

This comment has been minimized.

@alexeagle

alexeagle Mar 1, 2019

Contributor

nit: would be nice to comment what this is and why we don't want it (I assume it's for speed?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.