Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): Hide Bazel files in Bazel builder #29110

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

kyliau commented Mar 5, 2019

This commit modifies the Bazel builder to copy the Bazel WORKSPACE and
BUILD.bazel files to the project root directory before invoking Bazel.

This hides the Bazel files from users.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Mar 5, 2019

@ngbot ngbot bot modified the milestone: needsTriage Mar 5, 2019

@googlebot googlebot added the cla: yes label Mar 5, 2019

@kyliau kyliau force-pushed the kyliau:builder branch 3 times, most recently from 1f351e1 to 9bca2b6 Mar 5, 2019

@kyliau kyliau requested a review from angular/fw-integration as a code owner Mar 5, 2019

@kyliau kyliau force-pushed the kyliau:builder branch from 9bca2b6 to a7f4783 Mar 5, 2019

@kyliau kyliau removed the PR state: WIP label Mar 5, 2019

@kyliau kyliau requested review from alexeagle and hansl Mar 5, 2019

@kyliau kyliau force-pushed the kyliau:builder branch from a7f4783 to f67aeb7 Mar 6, 2019

@kyliau

This comment has been minimized.

Copy link
Member Author

kyliau commented Mar 6, 2019

Added safeguard to not overwrite existing Bazel files, removed hard-coded Bazel file paths, and converted implementation to use Promise.
PTAL.

@kyliau kyliau force-pushed the kyliau:builder branch from f67aeb7 to ed2f675 Mar 6, 2019

@hansl

hansl approved these changes Mar 6, 2019

feat(bazel): Hide Bazel files in Bazel builder
This commit modifies the Bazel builder to copy the Bazel WORKSPACE and
BUILD.bazel files to the project root directory before invoking Bazel.

This hides the Bazel files from users.

@kyliau kyliau force-pushed the kyliau:builder branch from ed2f675 to 4ee9b8f Mar 7, 2019

@kara kara closed this in 7060d90 Mar 7, 2019

@kyliau kyliau deleted the kyliau:builder branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.