Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform-server): wait on returned BEFORE_APP_SERIALIZED promises #29120

Closed

Conversation

Projects
None yet
3 participants
@adamdbradley
Copy link
Contributor

commented Mar 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Render does not wait on any returned promises from BEFORE_APP_SERIALIZED.

What is the new behavior?

This update gives external tooling the ability for async providers to
finish resolving before the document is serialized. This is not a
breaking change since render already returns a promise. All returned
promises from BEFORE_APP_SERIALIZED providers will wait to be
resolved or rejected. Any rejected promises will only console.warn().

Does this PR introduce a breaking change?

  • Yes
  • No

@adamdbradley adamdbradley requested a review from angular/fw-server as a code owner Mar 5, 2019

@googlebot googlebot added the cla: yes label Mar 5, 2019

@adamdbradley adamdbradley changed the title feat(server): wait on returned BEFORE_APP_SERIALIZED promises feat(platform-server): wait on returned BEFORE_APP_SERIALIZED promises Mar 5, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 5, 2019

@vikerman vikerman self-assigned this Mar 5, 2019

feat(platform-server): wait on returned BEFORE_APP_SERIALIZED promises
This update gives external tooling the ability for async providers to
finish resolving before the document is serialized. This is not a
breaking change since render already returns a promise. All returned
promises from `BEFORE_APP_SERIALIZED` providers will wait to be
resolved or rejected. Any rejected promises will only console.warn().

@adamdbradley adamdbradley force-pushed the adamdbradley:async-before-serialize branch from 7e93a82 to 317a52f Mar 6, 2019

@adamdbradley adamdbradley deleted the adamdbradley:async-before-serialize branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.